Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a display mode? #63

Closed
Tracked by #75
kuchaguangjie opened this issue Aug 7, 2022 · 8 comments
Closed
Tracked by #75

Is there a display mode? #63

kuchaguangjie opened this issue Aug 7, 2022 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@kuchaguangjie
Copy link

kuchaguangjie commented Aug 7, 2022

After creating the content, I want to display a readonly view.
Thus show tags in read only mode, adding disable="true" can make it read only.

But, there could be some improvements:

  • when hover, don't show the mouse as disabled,
  • add optional links to the tags, (e.g search by tag), maybe via a callback function on click.
@agustinl agustinl added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Aug 16, 2022
@agustinl
Copy link
Owner

Hi @kuchaguangjie I will take a look for your requests soon. Thanks for your patience!

@levex
Copy link

levex commented Oct 24, 2022

This would be a very well welcomed enhancement. :-)

@agustinl
Copy link
Owner

Hi @kuchaguangjie

Could you explain a little more the secon item?

Thxs!

@kuchaguangjie
Copy link
Author

On click a tag, trigger a function, which pass the tag's text as arguments, e.g the callback function and do a search in database with the tag as condition.

@agustinl
Copy link
Owner

Hi @kuchaguangjie @levex

Working on it 🚀

Will very helpful if you can test from your side.

If you add readonly prop, now the input show disabled but with normal styles.
And onTagClick allow to pass a fn to execute when you click a tag element. Its returns the tag (text or object).

@kuchaguangjie
Copy link
Author

@agustinl Nice job,if u make a beta release/tag, I can test it, thanks.

@levex
Copy link

levex commented Nov 23, 2022

Hi @kuchaguangjie @levex

Working on it 🚀

Will very helpful if you can test from your side.

If you add readonly prop, now the input show disabled but with normal styles.

And onTagClick allow to pass a fn to execute when you click a tag element. Its returns the tag (text or object).

Thanks a lot! I will be testing your branch in the coming days. :-)

@agustinl agustinl mentioned this issue Dec 8, 2022
4 tasks
@agustinl
Copy link
Owner

agustinl commented Dec 8, 2022

@kuchaguangjie @levex merged 🚀

@agustinl agustinl closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants