Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: styling of the modal(s) #86

Closed
ihodes opened this issue Mar 25, 2021 · 6 comments
Closed

Feature request: styling of the modal(s) #86

ihodes opened this issue Mar 25, 2021 · 6 comments

Comments

@ihodes
Copy link

ihodes commented Mar 25, 2021

It would be nice to be able to style the modals, including how text is displayed (e.g. cmd → ⌘).

@jaidetree
Copy link
Collaborator

This would also be doable with the advising system proposed in #72. Sounds like I better get cracking on this 😅

@ihodes
Copy link
Author

ihodes commented Mar 27, 2021

Sorry for the bombardment with all these feature requests! I am a big fan of spacehammer and am super impressed with what you've done. also love fennel, as I'm a long-time Clojurer. I hope to get a contribution in, and might start familiarizing myself by getting deeper into my config to address #85 :)

@jaidetree
Copy link
Collaborator

Excellent, a fellow Clojurist! Thanks for reporting the issues, and feature requests separately. We appreciate the community activity either way. The discussions https://github.com/agzam/spacehammer/discussions might be a good medium if you end up getting stuck somewhere.

@agzam
Copy link
Owner

agzam commented Mar 28, 2021

Sorry for the bombardment with all these feature requests!

Oh no, please don't hesitate to share any ideas - good or bad, mediocre or exceptional. Remember, this project grew out of some hobby attempts to improve my own workflow. It is very opinionated, and I never thought it would be useful for anyone else.

It still suffers from many careless design decisions I made in the beginning. I've been using Spacehammer for a few years now, and I get used to it too much. In many aspects - "it just works for me." But that doesn't mean that either I or @eccentric-j are not interested in improving it further. Please keep sharing the ideas, and tell us how we can do better.

@jaidetree
Copy link
Collaborator

Now that #107 is merged, it should be trivial to make the formatting functions advisable so users can tweak it to their liking

@jaidetree
Copy link
Collaborator

Here is an example:

(defadvice red-alert
           [str style seconds]
           :before alert
           "Customize the modal UI to make the text color red"
           (pprint style) ;; See what the default style props are
           (tset style :textColor { :red 1 :alpha 1}))

You can drop that into your config.fnl and tweak the style object. More details can be found at https://www.hammerspoon.org/docs/hs.alert.html#defaultStyle. Feel free to reopen if this doesn't cut it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants