-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins which compile to different paths won't ever be removed from cache #1
Comments
Good find! You're definitely right; the I'm not sure addressing this problem is within the scope of what this plugin aims to achieve. I imagine to solve this problem you're keeping track in your watcher callback of what files may have a different path in the remember cache? E.g. if the path ends in Curious what thoughts you have on how this could be addressed in a generic manner. |
I'm still working this into my build process, so I think I'll come up with a better idea. For now I forked gulp-remember and simply stripped off the extension when caching and deleting from the cache (since that works for my specific use cases). Still thinking about it though. |
I don't think I'm comfortable with merging the fix you have for this, as there could be files with the same path but different extensions within your source. For example, As I think about it more, taking care of passing the correct path to If you think of some messaging or suggestions to add to the readme as a warning for this case, by all means shoot it my way. |
Scenario:
You have a bunch of
.coffee
files.During the build process you transpile those to
.js
and then youremember()
them. Since you're remembering the transpiled versions, theirpath
will be altered frompath/to/file/foo.coffee
topath/to/file/foo.js
.Then when you delete that file, the lookup for the path will not find the
path/to/file/foo.js
since that's not the original path name. So in other words, after you delete your source file, it will continue to be pulled back in and never actually removed.This will happen for any file when the original extension changes during the build process.
The text was updated successfully, but these errors were encountered: