Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter case #21

Closed
TrySound opened this issue Apr 8, 2016 · 5 comments
Closed

Letter case #21

TrySound opened this issue Apr 8, 2016 · 5 comments
Assignees

Comments

@TrySound
Copy link

TrySound commented Apr 8, 2016

Paths SomeThing and something are equal. You should cache it in lower case and lowercase before check.

@ahaurw01
Copy link
Owner

ahaurw01 commented Apr 8, 2016

Good find, thanks. Did you come across this by renaming files during your build process or something? I can patch this at some point, or feel free to beat me to it with a PR.

@ahaurw01 ahaurw01 self-assigned this Apr 8, 2016
@TrySound
Copy link
Author

TrySound commented Apr 8, 2016

@ahaurw01 Yeah. It's angular. I'm trying to find a good name for directive which evaluates like this
ABComponent -> <a-b-component></a-b-component>
AbComponent -> <ab-component></ab-component>
And I don't have access to external repos on my work. So would be good if you will find a time.

@TrySound
Copy link
Author

TrySound commented Apr 8, 2016

I think path should be lowercased in this places.
https://github.com/ahaurw01/gulp-remember/blob/master/index.js#L27
https://github.com/ahaurw01/gulp-remember/blob/master/index.js#L64

@ahaurw01
Copy link
Owner

ahaurw01 commented Apr 8, 2016

Just published a new version. Let me know if anything is amiss.

@ahaurw01 ahaurw01 closed this as completed Apr 8, 2016
@TrySound
Copy link
Author

TrySound commented Apr 8, 2016

@ahaurw01 Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants