Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle invalid base32 characters #60

Closed
ahawker opened this issue Oct 26, 2017 · 0 comments
Closed

Properly handle invalid base32 characters #60

ahawker opened this issue Oct 26, 2017 · 0 comments
Assignees
Labels

Comments

@ahawker
Copy link
Owner

ahawker commented Oct 26, 2017

As of today, it is possible to input non-base32 characters, uU for example, into any of the api calls.

Doing this will cause the library to fail silently and perform an incorrect base32 decode on the string.

The API should provide a feedback mechanism that informs the caller of the bad input. The implementation of that feedback is still TBD (separate API call vs. exception vs. ??).

Considerations:

  • Performance of this computation for every decode call?
  • Double-penality for callers that have already made this guarantee?
  • Separate API call to validate? Is there use-cases for this outside of normal hot path?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant