Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-ascii character tests #61

Closed
ahawker opened this issue Oct 28, 2017 · 0 comments · Fixed by #62
Closed

Fix non-ascii character tests #61

ahawker opened this issue Oct 28, 2017 · 0 comments · Fixed by #62
Assignees
Labels

Comments

@ahawker
Copy link
Owner

ahawker commented Oct 28, 2017

There are a number of tests based off the invalid_str_encoding fixture that are passing but the assert is being fulfilled by an incorrect code path.

  • Investigate best way to assert against exception message (pattern matching hopefully)
  • Fix tests and assert correct exception from expected code path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant