Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Typo on command.js #505

Closed
samypr100 opened this issue Mar 1, 2016 · 1 comment
Closed

Potential Typo on command.js #505

samypr100 opened this issue Mar 1, 2016 · 1 comment

Comments

@samypr100
Copy link

On line 227 with the latest commit being d8e8d84
There's might be a typo.. and it's throwing a lot when we blast it with a lot of images with potential errors in that line. I couldn't find any documentation to stdin.once in any of the docs. It's saying:

"TypeError: Cannot read property 'once' of undefined"

Hence, instead of:

proc.stdin.once('error', cb);

Shouldn't it be (or something else, or should we do check if the stdin even exists):

proc.stdin.on('error', cb);

I'm using NodeJS LTS.

@samypr100 samypr100 changed the title Typo on command.js Potential Typo on command.js Mar 1, 2016
@samypr100
Copy link
Author

Nevermind, figured out what once is.
The issue I was having was spawn EGAIN after the call stack exceeded due to the amount of files and the processes required to be spawn. After it hits the limit, spawn doesn't work well in NodeJS, at first it starts by being set to undefined and later starts throwing EGAIN spawn errors.
Issue #42 comments at the end helped a great deal.
I ended up using AsyncJS limit iterator in order to avoid going past the limits.
I wonder if there's a way to properly catch this error though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant