New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curious about the reason you started from scratch #10
Comments
I believe this library started as a utility for the |
@refack Thanks for the quick answer. |
IMHO, tiny A+ promise implementation like
If your only goal is to add optional promise support with minimal overhead then it's natural to choose some minimalistic implementations like |
@lbeschastny I would pick performance and testing every time over payload size for NodeJS. Regarding performance, have a look at this article.
|
Most important to me is debuggability. |
this was the result of specific needs for mongoose and the other libs didn't support quite the right features (EventEmitter based with custom event names). I'm not a fan of adding more features to this lib. The goal was to be Promises A+ compat so it works with the other popular libs. Wouldn't mind swapping out this for Q or bluebird etc within mongoose. Very doable with some light shims. mongoose-bluebird, mongoose-q or something. |
Is there a particular reason while you would started your own promise library from scratch vs. leveraging the work of an existing one (like q or the very well-crafted bluebird)?
I do think breaking down Mongoose in smaller modules is a great idea, but I'm curious why you did not want to leverage proven existing work.
The text was updated successfully, but these errors were encountered: