Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regular sheet animation disappeared when I add the Popover package via Swift Package Manager #25

Closed
tm00-git opened this issue Feb 23, 2022 · 7 comments
Assignees
Labels
bug Something isn't working fixed The problem was fixed!

Comments

@tm00-git
Copy link

regular sheets (i.e. .sheet(isPresented: <Binding>, onDismiss: <(() -> Void)?(() -> Void)?() -> Void>, content: <() -> View>) ) I use across the app appearance stopped animating. Animation is restored when popover package is removed.

@aheze
Copy link
Owner

aheze commented Feb 24, 2022

@tm00-git what version of Popovers are you using? Popovers v1.2 had some known issues with system animations interference - Popovers v1.3 should fix them.

@tm00-git
Copy link
Author

tm00-git commented Feb 24, 2022

@aheze thank you for prompt reply. I indeed installed latest package 1.3.0 and tested multiple times. It appears regular sheet loses animation if it is attached to NavigationView. Attaching two gifs to demonstrate behaviour.
Without Popovers - sheet animation is working
Without Popovers

With Popovers - sheet animation is lost:
With Popovers 1 3 0

@aheze
Copy link
Owner

aheze commented Feb 25, 2022

Weird. For now try attaching the .popover modifier somewhere other than the sheet — if you use a .relative position, where it's attached doesn't matter.

@aheze aheze added the bug Something isn't working label Feb 25, 2022
@aheze aheze self-assigned this Feb 25, 2022
@tm00-git
Copy link
Author

the strange thing is that animations on regular sheet stops working as soon thePopovers package (v 1.3.0) is added through Xcode package manager, even without attaching .popover. Could be related with modifiers which overwrites system defaults.

@Nickersoft
Copy link

Would just like to hop in here and say that I'm experiencing the same 👋🏼

@aheze
Copy link
Owner

aheze commented Mar 7, 2022

Hmm ok. I’m super busy this week but will check it out as soon as I can

@aheze aheze added the help wanted Extra attention is needed label Mar 7, 2022
@aheze
Copy link
Owner

aheze commented Apr 29, 2022

@tm00-git @Nickersoft fixed in https://github.com/aheze/Popovers/releases/tag/1.3.2.

@aheze aheze closed this as completed Apr 29, 2022
@aheze aheze added fixed The problem was fixed! and removed help wanted Extra attention is needed labels Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed The problem was fixed!
Projects
None yet
Development

No branches or pull requests

3 participants