Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll doesn't work in the example app #8

Open
arietis opened this issue Jun 4, 2023 · 4 comments
Open

Scroll doesn't work in the example app #8

arietis opened this issue Jun 4, 2023 · 4 comments

Comments

@arietis
Copy link

arietis commented Jun 4, 2023

Whenever I try to scroll up or down in the example app, it only works if I use the left or right edge of the screen. Does it work inside scroll views?

@MirzayevFarid
Copy link

+1

@joshgalvan
Copy link

joshgalvan commented Jun 7, 2023

I am also not able to place a SwipeView with a SwipeAction inside a ScrollView without the ScrollView not being able to be moved at all. It seems the placement of the SwipeView in a ScrollView overrides any vertical gesture detection, only capturing horizontal gesture movement for the SwipeView that you initially started your gesture on.

If you add enough padding between SwipeViews in a ScrollView you can press between the SwipeViews and get the ScrollView to detect the vertical movement of your gesture. How to stop the SwipeView from overriding vertical movement detection by the ScrollView? Not sure...

It may have to do something with line 442, where highPriorityGesture() is used, which overrides other gestures currently available?

EDIT: I fixed my issue by modifying the SwipeView with .swipeMinimumDistance(20). For my situation this seemed to work well and not interfere with the ScrollView. I feel like this should be default behavior though.

@minho-park
Copy link

I think we should use gesture() instead of highPriorityGesture() of line 442.
It doesn't need highPriority.

@freak4pc
Copy link

freak4pc commented Apr 7, 2024

Just bumped into this and wanted to highlight this solved the issue for me as well :)
2 is a very small number as a default IMO

EDIT: I fixed my issue by modifying the SwipeView with .swipeMinimumDistance(20). For my situation this seemed to work well and not interfere with the ScrollView. I feel like this should be default behavior though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants