Bug fix on cli, uped min version reqirement and fix with import in py…

…torch dataloader
ahmed-shariff · Sep 16, 2019 · 16f7d65 · 16f7d65
1 parent 02dc7fb
commit 16f7d65
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/mlpipeline/_cli.py b/mlpipeline/_cli.py
@@ -146,17 +146,14 @@ def process_pipeline_single(config, whitelist_versions, blacklist_versions, b, *
             blacklist_versions = None
             executed_versions.append(whitelist_versions)
             whitelist_versions = [whitelist_versions]
-        p = Process(target=_execute_exeperiment,
-                    kwargs={
-                        'file_path': config.listed_experiments[0],
-                        'experiments_dir': config.experiments_dir,
-                        'experiment_mode': config.experiment_mode,
-                        'no_log': config.no_log,
-                        'whitelist_versions': whitelist_versions,
-                        'blacklist_versions': blacklist_versions,
-                        'mlflow_tracking_uri': config.mlflow_tracking_uri,
-                        '_cmd_mode': True
-                    })
+        p = _execute_exeperiment_process(file_path=config.listed_experiments[0],
+                                         experiments_dir=config.experiments_dir,
+                                         experiment_mode=config.experiment_mode,
+                                         no_log=config.no_log,
+                                         whitelist_versions=whitelist_versions,
+                                         blacklist_versions=blacklist_versions,
+                                         _cmd_mode=True,
+                                         mlflow_tracking_uri=config.mlflow_tracking_uri)
         p.start()
         p.join()
         exitcode = p.exitcode

diff --git a/mlpipeline/_pipeline.py b/mlpipeline/_pipeline.py
@@ -14,7 +14,7 @@
 from mlpipeline._pipeline_subprocess import _execute_exeperiment_process
 import mlpipeline._default_configurations as _default_config
 # why not check for this
-if sys.version_info < (3, 5):
+if sys.version_info < (3, 5, 5):
     sys.stderr.write("ERROR: python version should be greater than or equal 3.5\n")
     sys.exit(1)
 

diff --git a/mlpipeline/pytorch/_dataloader.py b/mlpipeline/pytorch/_dataloader.py
@@ -1,4 +1,4 @@
-import torch
+import torch.utils.data
 from mlpipeline.base import DataLoaderABC
 from mlpipeline.entities import ExecutionModeKeys