Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup is scroll to the top of page, causing some of the highlighted content to overflow from the screen #4

Closed
cjb5333 opened this issue Jan 13, 2017 · 3 comments

Comments

@cjb5333
Copy link

cjb5333 commented Jan 13, 2017

Your directive is very helpful - helped me escape a jquery dependency on other directive :)

When using left and right positions, the popup scrolls to top; however, since the popup is centered on the element and the top of the element extends past the top of the popup, it is cut off the screen.

I'm not sure if i'm doing something wrong or if this should be an issue, thanks!

@ahmed-wagdi
Copy link
Owner

I'm glad you found it helpful :)

Could you send a screenshot of the problem?

@cjb5333
Copy link
Author

cjb5333 commented Jan 13, 2017

I took 2 screenshots, but had to remove any PI.

This is the full element, and how I would expect it to be position with respect to the top of the page. In this screenshot, the top of the image is the top of the screen:
angular-joyride_good

This is the screenshot of how it actually renders and where it scrolls to. Again, the top of the image is the top of the screen, and you can see that the top part of the element from the previous screenshot is hidden and off the page:
angular-joyride_bad

@ahmed-wagdi
Copy link
Owner

So you're saying that the the window scrolls to the top of the joyride popup but it should be scrolling to the top of the highlighted element instead correct?

If that's the case then i'm not really getting the same issue, i created a plunkr here where it seems to be working fine: https://plnkr.co/edit/OagapaIJ5GxO1QKHTqNj?p=preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants