Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feature requests!! #8

Open
ridwan47 opened this issue Jun 7, 2021 · 9 comments
Open

Some feature requests!! #8

ridwan47 opened this issue Jun 7, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@ridwan47
Copy link

ridwan47 commented Jun 7, 2021

Important

  1. Allow Pause/Resume Support
  2. Allow Resume of unfinished/interrupted downloads. Right now it downloads the entire
    course from the beginning.
  3. Don't use [] Brackets in numbers. Video players doesn't play videos chronologically.
    Just name it normally like: 01 Introduction.mp4 instead of [1] Introduction.mp4

Wishful request

  1. Allow only subtitle download (without video)
  2. Automatically download thumbnail of the course.
    Not very important, would be very nice.
@ahmedayman4a ahmedayman4a added the enhancement New feature or request label Jun 8, 2021
@ahmedayman4a
Copy link
Owner

I really like these features but I am quite busy currently. I will try to add some of these features when I have the time

@ridwan47
Copy link
Author

ridwan47 commented Jun 8, 2021

I really like these features but I am quite busy currently. I will try to add some of these features when I have the time

Thanks for your consideration.

@Jabe64
Copy link

Jabe64 commented Jun 8, 2021

Hi!

Thanks a lot @ahmedayman4a for your software and @ridwan47 for your suggestions.

I totally agree with No.3 and about it I will add that it will be great to detect the default name and use it.

For example if the folder is named by default "2. Name of the chapter", to be able to rename it automatically into "02 - Name of the chapter".

And for the videos inside this folder rename them : "02-01 - Name of the first video of the second folder", "02-02 - Lorem ipsum" and so on. And why not rename "Introduction" folder to "00 - Introduction".

I don't know if it's very clear but that's how I name my files and for the moment I rename them manually, remove the brackets, etc.

@ridwan47
Copy link
Author

ridwan47 commented Jun 8, 2021

for the moment I rename them manually, remove the brackets

You can use a great software called ReNamer by den4b to do this automatically when you have a lot of files to rename. It saves a lot of time!

@Jabe64
Copy link

Jabe64 commented Jun 8, 2021

for the moment I rename them manually, remove the brackets

You can use a great software called ReNamer by den4b to do this automatically when you have a lot of files to rename. It saves a lot of time!

@ridwan47 Thanks a lot for the tip I will have a look at it.

@ahmedayman4a
Copy link
Owner

ahmedayman4a commented Jun 9, 2021

Looks like feature number 3 is urgent so I will add it soon.
I have a question though, which folder structure is better:

├───01 - Chapter 1
│   ├───01 - Video 1
│   └───02 - Video 2
└───02 - Chapter 2
    ├───01 - Video 1
    └───02 - Video 2

Or this

├───01 - Chapter 1
│   ├───01 - 01 - Video 1
│   └───01 - 02 - Video 2
└───02 - Chapter 2
    ├───02 - 01 - Video 1
    └───02 - 02 - Video 2

And why? Does it matter for the video player? Doesn't the video player go through the first folder then all its videos then the second folder. Or does it get all videos and sort them without regard for folder names?

@ahmedayman4a ahmedayman4a added this to the v1.2 milestone Jun 9, 2021
@Jabe64
Copy link

Jabe64 commented Jun 9, 2021

Looks like feature number 3 is urgent so I will add it soon.
I have a question though, which folder structure is better:

├───01 - Chapter 1
│   ├───01 - Video 1
│   └───02 - Video 2
└───02 - Chapter 1
    ├───01 - Video 1
    └───02 - Video 2

Or this

├───01 - Chapter 1
│   ├───01 - 01 - Video 1
│   └───01 - 02 - Video 2
└───02 - Chapter 1
    ├───02 - 01 - Video 1
    └───02 - 02 - Video 2

And why? Does it matter for the video player? Doesn't the video player go through the first folder then all its videos then the second folder. Or does it get all videos and sort them without regard for folder names?

Thanks for your fast answer. For my video player both structure work.
I rename my videos according to second folder structure or very close to it, I just don't put space between chapter number and video number to make it more compact "01-01 - Video 1".

The reason I rather like second folder structure is that if for some reason I send 1 video only to a friend or if I copy only one video of a chapter somewhere, I know quickly where this video was from. The other reason is that if for some reason I put all video files in a single folder with a playlist (without subfolders) it will be organized in the correct order.

But it's also a personal taste, I'm not saying that I'm right. I know some people rather like "01.01" instead of "01-01" for example. Maybe there could be some configuration menu for the user to choose between several naming conventions?

@ahmedayman4a
Copy link
Owner

I like your naming scheme. I will add it to the app.

@ridwan47
Copy link
Author

ridwan47 commented Jun 9, 2021

Looks like feature number 3 is urgent so I will add it soon.
I have a question though, which folder structure is better:

I like the 1st version. Since all the chapters are inside folders there is no need for chapter chronology number with video files.

Let me show you how I rename my courses after downloading.

For folders

For Folders

And for files

For Files

Notice in addition of removing brackets I also add '0' before each numbers because that helps when you have more than 9 folders/files. This to make single digits in to double digits. Don't add 0 before 10 (double digit numbers).

@ahmedayman4a ahmedayman4a removed this from the v1.2 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants