v2.0

[kalaninja]

Hi there,
I've managed to deal with all my "busy man" problems. So, back online and ready for some opensource.

Here is the PR for v2.0. It doesn't have a readme file yet, because I am unaware about the links to godoc, travis, etc. I assume that if we tag the new commit with as "v2.0", the link to godoc would be smth like
https://godoc.org/gopkg.in/ahmetalpbalkan/go-linq.v2.0 and it seems that tha branch for travis and coveralls can be specified at their urls. Is it correct? Should I tag it myself?

[ahmetb]

@kalaninja thanks for this PR! Don't worry about README etc for now, we can address the docs/website issues later.

Do you mind giving a brief overview of how much exported function/type signatures have changed? That would help me to review and give an idea of how much of a breaking change it is.

[ahmetb]

I guess this one is a leftover. Can you please revert this file?

[kalaninja]

Sure. Didn't notice that.

[kalaninja]

About an overview it seems to be a good idea? How do you want to have that info? I may do it as a table in excel or google docs with my methods on one side and yours on the other? Or you might have a better idea?

[ahmetb]

@kalaninja actually, I think I got the main idea. There are quite many new methods, some methods are gone, errors are gone, linq.T is now interface{} etc.

I also found godocs to be helpful. How about you add a README.md (by updating the old one?) in the meanwhile and I give you commit access after merging this. The remaining tasks would be:

• we should probably add a big notice to the README.md saying v2.0 is a breaking change, for those who want, we can link to a v1.0 branch
  • for that we first need to tag a v1.0 branch :) this can be done later.
• update README with new examples
• update Wiki tab with new examples (or maybe get rid of the wiki altogether, WDYT?)
• update the gh-pages branch for the website with new examples

[kalaninja]

Yes, I don't have error because they made the predicates look ugly, and its effect can be achieved with panic and recover.
Yes, I used interface{} instead of linq.T, but now I am unsure about that decision, probably usage of linq.T made the code look prettier. WDYT?

I'll do the readme asap. Agree with the todo list. And I do not believe that the wiki is really helpful (I didn't even know that you have one)) You have a beautiful site and we might invest more effort there.

[ahmetb]

this code can be shorter as?:

switch{
case a>b: return -1
case b<a: return 1
default: return 0
}

[kalaninja]

they seem pretty the same legth since I use gofmt

            switch {
            case a > b:
                return -1
            case b < a:
                return 1
            default:
                return 0
            }

vs

            if a < b {
                return -1
            } else if a > b {
                return 1
            }

            return 0

There are other variants as well. Consider:

            if a < b {
                return -1
            }
            if a > b {
                return 1
            }
            return 0

WDYT?

[ahmetb]

I guess it doesn't matter too much then. I still prefer

    switch {
    case a > b:
        return -1
    case b < a:
        return 1
    default:
        return 0
    }

mostly because it's easier to follow

[kalaninja]

Yes, I agree. It looks really straightforward. I'll change that.

[ahmetb]

@kalaninja This generally looks good to me. Can you just add a README by copying from the current one and updating the example etc. Then it would be good to merge. Then we can address other stuff in #30 (comment).

[kalaninja]

I've attached the readme, changed "if" to "switch" and removed the book struct from the example.

[ahmetb]

Maybe don't link to these like v2 yet because we'll merge it to master.

[kalaninja]

And what will happen with the current version?

[ahmetb]

I archived the current version in archive/0.9 branch, anybody who wants to use it I guess can grab it from there or perhaps grab it via go get gopkg.in/... (we have a v0.9-rc5 tag, we can tag it as v0.9 anytime if that'll make it work with gopkg.in).

[kalaninja]

I've fixed links in readme, removed the line about plinq, recovered the one about vanilla go, added release notes.
I've tried several ways to make the example more readable and ended with renaming a to author, b to book and g to group. I've added comments as well.

[ahmetb]

@kalaninja thanks! I'll open issues for the rest of the updates we probably need to make.

[ahmetb]

💥 🎊 🍷🍾