Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap grid doesn't actually unwrap? #20

Closed
alexgurr opened this issue Jul 5, 2019 · 2 comments
Closed

Unwrap grid doesn't actually unwrap? #20

alexgurr opened this issue Jul 5, 2019 · 2 comments

Comments

@alexgurr
Copy link

alexgurr commented Jul 5, 2019

I unwrap the grid, but when I try to rewrap it with wrapGrid I get uncaught exceptions? It looks like the unwrap is only for removing the observers/listeners - it doesn't clear up any state.
@aholachek
Copy link
Owner

Hi, thanks for catching this. I believe it's due to this line which doesn't account for pre-existing data attributes when the grid has been re-wrapped. I will hopefully get a patch release out sometime tomorrow or this weekend.

@aholachek
Copy link
Owner

just released 1.4.1 which should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aholachek @alexgurr