Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor's error handler throws errors #5

Closed
Bluebie opened this issue Apr 1, 2017 · 2 comments
Closed

monitor's error handler throws errors #5

Bluebie opened this issue Apr 1, 2017 · 2 comments

Comments

@Bluebie
Copy link

Bluebie commented Apr 1, 2017

On node v7.5.0 with miio v0.4.0:

(node:937) TypeError: Cannot read property 'stack' of undefined
    at getProperties.then.catch.err (node_modules/miio/device.js:193:44)
(node:937) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitWarning (internal/process/promises.js:69:15)
    at emitPendingUnhandledRejections (internal/process/promises.js:86:11)
    at runMicrotasksCallback (internal/process/next_tick.js:61:9)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
(node:937) TypeError: Cannot read property 'stack' of undefined
    at getProperties.then.catch.err (node_modules/miio/device.js:193:44)

This code has been moved in the current head but still exists at https://github.com/aholstenson/miio/blob/master/device.js#L240

@aholstenson
Copy link
Owner

Could you see if you have the same issue in 0.5.0? The error handling should be a bit more resilient now.

@aholstenson
Copy link
Owner

Closing this as I think it has been solved for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants