Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in email preview color #1

Open
ahr9n opened this issue Apr 26, 2022 · 3 comments · May be fixed by #3
Open

A bug in email preview color #1

ahr9n opened this issue Apr 26, 2022 · 3 comments · May be fixed by #3
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ahr9n
Copy link
Owner

ahr9n commented Apr 26, 2022

If the email is unread, it should appear with a white background. If the email has been read, it should appear with a gray background. That needs to be handled well.

@ahr9n ahr9n added bug Something isn't working good first issue Good for newcomers labels Apr 26, 2022
@Ruixi-Zhang
Copy link

Hi, I just tested the program and saw that this feature is already implemented in the inbox for receivers. Do you mean that you want to implement this feature in the sent section for the sender as well?

@ahr9n
Copy link
Owner Author

ahr9n commented Apr 27, 2022

I deleted all cache and checked again, so I think it was reversely implemented, it should be:

if (email.read === false) {
  item.style.backgroundColor = '#D3D3D3';
}else{
  item.style.backgroundColor = '#FFFFFF';
}

to display the grey color if an email is unread, otherwise the white color.

And, yes, in the sent mailbox section, it is not working. Any ideas? It should be working for all mailboxes, not only the inbox. Please, feel free to make a pull request.

@Ruixi-Zhang
Copy link

I think it is not working in the sent mailbox section. I will submit a pull request to fix it.

@Ruixi-Zhang Ruixi-Zhang linked a pull request Apr 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants