Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] tsc throwing unused parameter error on build #347

Closed
koonwen opened this issue Jul 18, 2023 · 1 comment
Closed

[typescript] tsc throwing unused parameter error on build #347

koonwen opened this issue Jul 18, 2023 · 1 comment
Labels
bug enhancement good first time issue target:typescript Issues related to the TypeScript backend (atdts)

Comments

@koonwen
Copy link
Contributor

koonwen commented Jul 18, 2023 •
edited

Previously addressed by issue. The fix only added comments to disable linting checks. If tsconfig.json has set "noUnusedParameters" : true, the compiler will throw the unused parameter error.

A quick & dirty fix is to drop in the // ts-nocheck comment at the top of the file which will disable all compiler checks for the entire file. (read)
@mjambon mjambon added bug enhancement target:typescript Issues related to the TypeScript backend (atdts) good first time issue labels Jul 18, 2023
@mjambon
Copy link
Collaborator

mjambon commented Jul 18, 2023

I like the quick and dirty solution. I'm marking the issue as "good first time issue" if anyone wants to take it.

@koonwen koonwen mentioned this issue Jul 25, 2023
Merged
3 tasks
@koonwen koonwen closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement good first time issue target:typescript Issues related to the TypeScript backend (atdts)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjambon @koonwen