Generalize params

dunyakirkali · Jan 1, 2020 · d8cf555 · d8cf555
1 parent ca9efe8
commit d8cf555
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/lib/onesky/resources/file.ex b/lib/onesky/resources/file.ex
@@ -20,7 +20,7 @@ defmodule Onesky.File do
   @doc """
   DELETE a file
   """
-  def delete_file(client, project_id, file) do
-    Tesla.delete(client, "/projects/#{project_id}/files?file_name=#{file["file_name"]}")
+  def delete_file(client, project_id, params) do
+    Tesla.delete(client, "/projects/#{project_id}/files", query: params)
   end
 end
diff --git a/lib/onesky/resources/translation.ex b/lib/onesky/resources/translation.ex
@@ -20,14 +20,14 @@ defmodule Onesky.Translation do
   @doc """
   LIST uploaded files
   """
-  def get_appstore_description(client, project_id, locale) do
-    Tesla.get(client, "/projects/#{project_id}/translations/app-descriptions?locale=#{locale["locale"]}")
+  def get_appstore_description(client, project_id, params) do
+    Tesla.get(client, "/projects/#{project_id}/translations/app-descriptions", query: params)
   end
 
   @doc """
   LIST uploaded files
   """
-  def get_translation_status(client, project_id, file) do
-    Tesla.get(client, "/projects/#{project_id}/translations/status?file_name=#{file["file_name"]}&locale=#{file["locale"]}")
+  def get_translation_status(client, project_id, params) do
+    Tesla.get(client, "/projects/#{project_id}/translations/status", query: params)
   end
 end
diff --git a/test/onesky/resources/file_test.exs b/test/onesky/resources/file_test.exs
@@ -42,7 +42,7 @@ defmodule FileTest do
 
   test "delete_file" do
     use_cassette "file#delete" do
-      file = %{"file_name" => "gettext_po_sample_file.po"}
+      file = [file_name: "gettext_po_sample_file.po"]
       {:ok, %Tesla.Env{} = env} = Onesky.client() |> Onesky.File.delete_file(322_927, file)
 
       assert env.status == 200

diff --git a/test/onesky/resources/translation_test.exs b/test/onesky/resources/translation_test.exs
@@ -24,7 +24,7 @@ defmodule TranslationTest do
 
   test "get_appstore_description" do
     use_cassette "translation#app_store" do
-      locale = %{"locale" => "en"}
+      locale = [locale: "en"]
       {:ok, %Tesla.Env{} = env} = Onesky.client() |> Onesky.Translation.get_appstore_description(322_974, locale)
 
       assert env.status == 200
@@ -39,7 +39,7 @@ defmodule TranslationTest do
 
   test "get_translation_status" do
     use_cassette "translation#status" do
-      file = %{"file_name" => "Localizable.strings", "locale" => "nl-NL"}
+      file = [file_name: "Localizable.strings", locale: "nl-NL"]
       {:ok, %Tesla.Env{} = env} = Onesky.client() |> Onesky.Translation.get_translation_status(314_254, file)
 
       assert env.status == 200