You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just upgraded to 1.0.0 and then to 1.1.0. I am using the manual response validation (more or less) as follows:
# in my middlewaredefinition=OpenapiFirst.load(...)response=@app.call(env)definition.request(Rack::Request.new(env)).response(Rack::Response[*response]).validate!
My response validation breaks in 1.1.0 with NoMethodError: undefined method 'join' for #<ActionDispatch::Response::RackBody:... on @rack_response.body.join in OpenapiFirst::RuntimeRequest (here) because my @rack_response.body is a ActionDispatch::Response::RackBody.
The text was updated successfully, but these errors were encountered:
MrBananaLord
changed the title
Manual response validation interface breaking change in 1.0.0->1.1.0 upgrade
Manual response validation breaking change in 1.0.0->1.1.0 upgrade
Jan 12, 2024
Hi. Thanks for the feedback. I have to admit that I was afraid something could go wrong here, but Rack::Lint did not complain (…). My fault.
I am wondering if there is some tooling in Rack that makes this part simpler. …
I will try to come up with a fix shortly to release 1.1.1
Hi!
I just upgraded to 1.0.0 and then to 1.1.0. I am using the manual response validation (more or less) as follows:
My response validation breaks in 1.1.0 with
NoMethodError: undefined method 'join' for #<ActionDispatch::Response::RackBody:...
on@rack_response.body.join
inOpenapiFirst::RuntimeRequest
(here) because my@rack_response.body
is aActionDispatch::Response::RackBody
.In the rack repo I found that the body is usually expected to respond to each or call so maybe we could go back to using each? :)
The text was updated successfully, but these errors were encountered: