Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

something wrong in bert_data.py? #2

Closed
sloth2012 opened this issue Dec 17, 2018 · 2 comments
Closed

something wrong in bert_data.py? #2

sloth2012 opened this issue Dec 17, 2018 · 2 comments

Comments

@sloth2012
Copy link

image
in the get_data funciton, should variable cls be a list?

@sloth2012
Copy link
Author

if that, cls2idx[cls] should be wrong.

the code is about in line 197 in modules.data.bert_data

@king-menin
Copy link
Collaborator

king-menin commented Dec 18, 2018

cls - is the label of class (usally str) or None if is_cls=False in get_data.
My bad is i didn't check any types of arguments.

PS. Maybe code should be simplify. But i think, that it works correctly (with right input data). If you have any suggestions of improving. Please, come on :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants