Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in main_metrics #28

Closed
brickee opened this issue Feb 3, 2020 · 1 comment
Closed

Mistake in main_metrics #28

brickee opened this issue Feb 3, 2020 · 1 comment

Comments

@brickee
Copy link

brickee commented Feb 3, 2020

current_tag = current_token.split('', 1)[-1] # replace '-' with ""
This bug will totoally change the evaluation result.
@king-menin
Copy link
Collaborator

king-menin commented Feb 3, 2020 •
edited

Maby you are right. You can do pull request with changes or try to use from modules.analyze_utils.plot_metrics import get_bert_span_report for mesure results.
Code from modules/analyze_utils/main_metrics.py was used for evaluation of FactRuEval dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@king-menin @brickee