Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance-improvement: make graph geometry creation faster in viewer #50

Closed
rdnfn opened this issue Mar 17, 2021 · 0 comments · Fixed by #62
Closed

Performance-improvement: make graph geometry creation faster in viewer #50

rdnfn opened this issue Mar 17, 2021 · 0 comments · Fixed by #62
Assignees
@rdnfn
Labels
concerns: user-interface kind: enhancement New feature or request kind: performance performance improvement
Projects
GeoGraph

Comments

@rdnfn
Copy link
Member

rdnfn commented Mar 17, 2021

Description:
[In visualisation/graph_utils.py]

Since .loc is quite slow, you should be able to speed this up quite a lot by just initialising the node_gdf using rep_points: https://www.geeksforgeeks.org/creating-a-pandas-dataframe-using-list-of-tuples/

Originally posted by @herbiebradley in #47 (comment)
@rdnfn rdnfn added this to To do in GeoGraph via automation Mar 17, 2021
@rdnfn rdnfn self-assigned this Mar 17, 2021
@rdnfn rdnfn mentioned this issue Mar 17, 2021
Merged
@rdnfn rdnfn added the kind: enhancement New feature or request label Mar 17, 2021
@Croydon-Brixton Croydon-Brixton mentioned this issue Mar 25, 2021
Merged
@Croydon-Brixton Croydon-Brixton moved this from To do to Done in GeoGraph Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdnfn rdnfn

Labels
concerns: user-interface kind: enhancement New feature or request kind: performance performance improvement
Projects
GeoGraph
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/visualisation node diff ai4er-cdt/geograph
1 participant
@rdnfn