New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #190
Add tests #190
Conversation
Hi @zhumingpassional - let me know if you have any questions before merging this PR, thanks |
Hi @Athe-kunal - this is the PR that I've mentioned. Please check out the result of the first test case (the one above pre-commit.ci). Once it completes, it should fail, with some failures related to get_data() and get_trading_days(). can you help create issues in the project tracker so we start resolving those? Thanks!! |
|
I prefer writing a TestDataProcessor class, and put all test data processors there. This can reduce the number of test_xxx.py |
So you want to setup some time and discuss ? I don't see the premise of having less test files or just one class. I don't mind, but I don't think we should rework |
OK. i will merge it. |
I have added several tests: