Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor struct Query #6

Closed
miporto opened this issue Jun 15, 2018 · 1 comment
Closed

Refactor struct Query #6

miporto opened this issue Jun 15, 2018 · 1 comment
Assignees
@aibarbetta
Labels
critical enhancement New feature or request

Comments

@miporto
Copy link
Collaborator

miporto commented Jun 15, 2018 •
edited
Loading

The Query should support both messages to the Server and to the Client. So it should be named Message (and modified accordingly) as it is more appropriate.

It should also be refactored as it's shown in the attached image.
image
@miporto miporto added enhancement New feature or request critical labels Jun 15, 2018
@miporto miporto changed the title Rename Query to Message Refactor struct Query Jun 18, 2018
@aibarbetta aibarbetta self-assigned this Jun 18, 2018
@aibarbetta
Copy link
Owner

aibarbetta commented Jun 18, 2018 •
edited
Loading

  • memsets on every serialize
  • make serialize methods constant
  • separate Query from Entry
  • Move QueryData to Query.h

@aibarbetta aibarbetta mentioned this issue Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aibarbetta aibarbetta

Labels
critical enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miporto @aibarbetta