Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom is not following the pointer, but the middle of the screen #47

Closed
SahPet opened this issue Sep 9, 2022 · 4 comments
Closed

Zoom is not following the pointer, but the middle of the screen #47

SahPet opened this issue Sep 9, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@SahPet
Copy link

SahPet commented Sep 9, 2022

Two suggestions that would be a large improvement to user experience, in my opinion:

  1. Zooming is not following the position of the arrow/pointer in the image (like Qupath and many other WSI renderers), but always follows the middle of the screen. This makes it hard to navigate the image. Any way to make the zoom center around the arrow instead?

  2. Also, there is now way to navigate the image with the keyboard arrow keys. Navigating a lot of WSIs with the mouse only is very demanding for the wrist and most pathologists use the keyboard arrows as well.

@andreped andreped added the enhancement New feature or request label Sep 9, 2022
@andreped
Copy link
Member

andreped commented Sep 9, 2022

Suggestion (1) is something I have also wanted for a long time. Same with smoother movements including deaccelerations, similar to what QuPath (and OpenSeadragon used for LearnPathology) is doing.

@smistad
Copy link
Member

smistad commented Sep 12, 2022

Agreed. This can easily be added here: https://github.com/smistad/FAST/blob/master/source/FAST/Visualization/View.cpp#L702
However, the speed it should move towards the pointer might need to be optimized.

Support for arrow keys is also quite easy to add, but which keys to use for zooming in and out?

@SahPet
Copy link
Author

SahPet commented Sep 12, 2022

Sounds good:) One can always also add "+" and "-" as zoom keys, but I think most people just use mouse scroll together with the arrow keys. The hard part for the wrist is repeated "click-and-drag" movements, much more so than scrolling.

@smistad
Copy link
Member

smistad commented Oct 24, 2022

This has now been implemented in FAST and will appear in the next release. See commits smistad/FAST@d4c3311 and smistad/FAST@5c72bd8

@smistad smistad closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants