Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed File upload logic to handle large file size and improved error handling #36

Merged
merged 4 commits into from Feb 3, 2022
Merged

Changed File upload logic to handle large file size and improved error handling #36

merged 4 commits into from Feb 3, 2022

Conversation

Ushmajit
Copy link
Contributor

@Ushmajit Ushmajit commented Feb 3, 2022

Changes

  1. Improved error handling in the main module.
  2. Changed file upload logic to handle large file sizes. Reference : https://stackoverflow.com/questions/37336050/pipe-a-stream-to-s3-upload
  3. Created a driver file to easily test the module functionality.

Testing

E-2-E testing using driver.js

abose
abose reviewed Feb 3, 2022
View reviewed changes
src/aws_s3_client_module.js Outdated Show resolved Hide resolved
src/driver.js Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ushmajit
Copy link
Contributor Author

Ushmajit commented Feb 3, 2022

@abose Addressed your comments in the next commit

@Ushmajit Ushmajit merged commit 382a04f into main Feb 3, 2022
@Ushmajit Ushmajit deleted the test branch February 3, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abose abose abose left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ushmajit @abose