JEI Gas rendering fix and easier gas coloration #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes it for other tint based fluids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows gasses based on fluids only colored by a tint to render properly in JEI. This lets gasses created from MekaTweaker based on ContentTweaker fluids to render with a color in JEI, and also makes it so that ore slurry is colored in JEI. Example of osmium slurry in the chemical washer https://gyazo.com/a4f5fd3bd2a16415ffff2d840f01816a
I also decided to implement #5028 but in a different way to #5050 that makes it easier to edit the colors of gasses without having to recreate the entire texture. The reason I am including this in the same pull request is that it makes it easier to test the JEI rendering and having gas rendering work everywhere based on tint is needed for the change. (If you would like these in two separate pulls I can split them).
In addition to the changes of oxygen, tritium, lithium, and chlorine I have done the change requested on the pull of changing liquid osmium to a more blue-grey.
If you would like any of the other colors changed I can do so as it is very quick and easy to change the colors of the gasses now as all that is needed is a hex code.