Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss finally releasing 2.0 #27

Closed
aidantwoods opened this issue Mar 4, 2017 · 2 comments
Closed

Discuss finally releasing 2.0 #27

aidantwoods opened this issue Mar 4, 2017 · 2 comments
Milestone

Comments

@aidantwoods
Copy link
Owner

So everything is #19 is now complete. The documentation can now mostly be very nicely auto-generated from phpdoc. And we now have nice adapters to SecureHeaders can be used in arbitrary frameworks with very minor implementation code.

I'll make some additions to the test suit this weekend just to make sure everything is running nicely and as expected, but other than that I can't think of anything major that needs doing.

@franzliedke @lucasmichot feel free to jump in here if I've forgotten something that needs doing 😜

@aidantwoods aidantwoods added this to the 2.0 milestone Mar 4, 2017
@franzliedke
Copy link
Contributor

Yeah, ensuring with some test cases that all (implicit) behavior of v1.0 still works on 2.0 is my biggest (and only) concern as well. :)

The good thing is that you can still do bug fixes in patch releases, even though they are technically BC-breaking when they just restore behavior that was to be expected from v1.

@aidantwoods
Copy link
Owner Author

Definitely agree with this :) will make an effort to make sure everything I think should be happening is explicitly documented as well as adding tests in too. So that as you've said: if things aren't happening that are supposed to be happening, then we only need a patch release rather than a major version bump.

Will finish up those tests over the next day or so (have been a little sidetracked this week).

This was referenced Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants