Fix setting of run/event number offsets from the ddsim command line. #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ddsim --meta.runNumberOffset command-line argument doesn't work
correctly (and similarly for event number).
On a machine running
```
LSB Version: :core-4.1-amd64:core-4.1-ia32:core-4.1-noarch
Distributor ID: Scientific
Description: Scientific Linux release 7.3 (Nitrogen)
Release: 7.3
Codename: Nitrogen
```
I do
```
. /cvmfs/sw.hsf.org/key4hep/setup.sh
```
The then command
```
ddsim --compactFile $LCGEO/FCCee/compact/FCCee_o1_v05/FCCee_o1_v05.xml -G -N10 --outputFile out.edm4hep.root --meta.runNumberOffset 735001 2>&1|tee log
```
eventually crashes with the error
```
Geant4UI INFO +++ EventAction> Install Geant4 control directory:/ddg4/EventAction/
Traceback (most recent call last):
File "/cvmfs/sw.hsf.org/spackages7/dd4hep/1.23/x86_64-centos7-gcc11.2.0-opt/q4qtg/bin/ddsim", line 25, in <module>
RUNNER.run()
File "/cvmfs/sw.hsf.org/spackages7/dd4hep/1.23/x86_64-centos7-gcc11.2.0-opt/q4qtg/lib/python3.10/site-packages/DDSim/DD4hepSimulation.py", line 368, in run
e4Out.RunNumberOffset = self.meta.runNumberOffset if self.meta.runNumberOffset > 0 else 0
TypeError: '>' not supported between instances of 'str' and 'int'
*** Break *** segmentation violation
```
The arguments are never converted from strings to integers.
The change here fixes this.
andresailer
reviewed
Apr 21, 2023
andresailer
reviewed
Apr 21, 2023
DDSim,Meta: Fix formatting for dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ddsim --meta.runNumberOffset command-line argument doesn't work correctly (and similarly for event number).
On a machine running
I do
The then command
eventually crashes with the error
The arguments are never converted from strings to integers. The change here fixes this.
BEGINRELEASENOTES
ENDRELEASENOTES