Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put error context into the exception message instead of dumping to std::cout in DetectorImp::getRefChild() #1106

Merged
merged 2 commits into from May 31, 2023
Merged

Put error context into the exception message instead of dumping to std::cout in DetectorImp::getRefChild() #1106

merged 2 commits into from May 31, 2023

Conversation

veprbl
Copy link
Contributor

@veprbl veprbl commented May 4, 2023

BEGINRELEASENOTES

  • DetectorImp::getRefChild() will no longer print to error context to std::cout, it will instead appear in the message of the runtime_exception thrown.

ENDRELEASENOTES

@veprbl veprbl changed the title DDCore: embed error context into the exception message instead of printin in DetectorImp::getRefChild() Put error context into the exception message instead of dumping to std::cout in DetectorImp::getRefChild() May 4, 2023
@veprbl veprbl mentioned this pull request May 4, 2023
Closed
@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited

Test Results

       8 files         8 suites   5h 17m 1s ⏱️
   344 tests    344 ✔️ 0 💤 0 ❌
1 366 runs  1 366 ✔️ 0 💤 0 ❌

Results for commit c28a03f.

♻️ This comment has been updated with latest results.

wdconinc
wdconinc reviewed May 6, 2023
View reviewed changes
DDCore/src/DetectorImp.cpp Outdated Show resolved Hide resolved
@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) May 31, 2023 00:59
@MarkusFrankATcernch MarkusFrankATcernch merged commit 13481bf into AIDASoft:master May 31, 2023
15 checks passed
@wdconinc wdconinc mentioned this pull request Jul 4, 2023
Merged
wdconinc added a commit to eic/eic-spack that referenced this pull request Jul 5, 2023
@wdconinc
dd4hep: apply patches for PRs 1066, 1071, 1105, 1106 (#489)
4e18bc1 
### Briefly, what does this PR introduce?
This mainly adds support in
AIDASoft/DD4hep#1071, but also some quality of
life changes in AIDASoft/DD4hep#1106. The rest
are dependencies for patch context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @wdconinc @MarkusFrankATcernch