Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSim: Change Default Output config #1144

Merged
merged 7 commits into from Jul 17, 2023

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Jul 14, 2023

BEGINRELEASENOTES

  • DDSim: change the default output file name on how DD4hep was built. Fixes Adjust default output based on compiled format support #1101

    • Add outputConfig.forceLCIO, outputConfig.forceEDM4HEP, outputConfig.forceDD4HEP switches to force a particular output plugin
    • If LCIO was used, slcio is still the default
    • If EDM4hep was used but not LCIO, EDM4hep is the default and used for all root output files.
    • If neither LCIO or EDM4hep was used, then DD4hep's root output is used. Use the outputConfig.forceDD4HEP flag to use DD4hep's root output if EDM4hep is available as well
  • DDSim: remove python2 legacy shims

  • Geant4UIManager: fail when pre or post run commands are not successfully executed.

ENDRELEASENOTES

@andresailer
Copy link
Member Author

Any one has thoughts on "It is no longer possible to use the DD4hep root output of EDM4hep was used for the build."? I am not sure this is a good idea, sometimes probably nice for debugging... But I can't think of a nice and user friendly way at the moment.

@MarkusFrankATcernch
Copy link
Contributor

I would separate the file name from the output format and have some --lcio --edm4hep --root flags to determine the output format. If none is set, stay for backwards compatibility with the existing functionality.

I know this even adds more flags, but ddsim anyhow lives from flags.

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Test Results

       6 files         6 suites   6h 47m 55s ⏱️
   355 tests    355 ✔️ 0 💤 0
1 055 runs  1 055 ✔️ 0 💤 0

Results for commit 88e828b.

♻️ This comment has been updated with latest results.

@andresailer
Copy link
Member Author

I added some flags (outputConfig.forceLCIO, outputConfig.forceEDM4HEP, outputConfig.forceDD4HEP) to force a given output format.
That should also make the RICH tests pass again.

Thanks @MarkusFrankATcernch

@andresailer andresailer merged commit 41f4004 into AIDASoft:master Jul 17, 2023
14 checks passed
@andresailer andresailer deleted the outputConfig branch July 18, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust default output based on compiled format support
2 participants