Fixed the G4Sphere construction using delta angles #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- G4Sphere uses delta theta/phi instead of TGeo's ending angles phi2/theta2.
|
@whit2333 Thanks for spotting this. I thought we found all these occurrences before in the tube segments etc. Apparently Spheres are not terribly widely used.... |
|
@MarkusFrankATcernch Yes, the tests were already failing in master before I merged something else yesterday. Something to do with ROOT master, or other changes in dev3 |
|
@andresailer You will have to do the merge. My karma is insufficient here..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#848
BEGINRELEASENOTES
ENDRELEASENOTES