[gdmlFile] optionally import physvol below top level #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows syntax like
```xml
<detectors>
<detector id="1" name="FT_MT" type="DD4hep_GdmlDetector" vis="InvisibleWithChildren">
<gdmlFile ref="GdmlDetector.gdml" physvol="lvUpstreamRegion_0"/>
<parent name="/world"/>
</detector>
</detectors>
```
to only load the specific `physvol` in `examples/ClientTests/compact/GdmlDetector.gdml`.
|
This looks like a valid enhancement of the GDML plugin. |
|
Failing check on dev3/x86_64-centos7-clang10-opt currently also fails on master itself. |
wdconinc
deleted the
gdml-plugins-import-top-level-volume-instead-of-world
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows syntax like
to only load the specific physvol in examples/ClientTests/compact/GdmlDetector.gdml.
The benefit of this is to allow imports of gdml assemblies or volumes into the existing world without having to import a separate gdml world. This can be used to great effect when there would otherwise be overlaps between volumes placed by dd4hep and the world volume in gdml.
Comments welcome.
BEGINRELEASENOTES
ENDRELEASENOTES