Require compatible podio version #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK. This will also fix if the podio version for DDG4, which in deed needs the same. |
andresailer
reviewed
Jan 30, 2023
|
And if you could change this DD4hep/.github/workflows/clang-tidy.yml Line 11 in 4f6c0b5 To LCG: ["dev4/x86_64-centos7-clang12-opt"] That should fix the error there. Thanks! |
andresailer
force-pushed
the
cmake-podio-version
branch
from
a144a55
to
00ffaa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe DDDigi implicitly requires podio>=0.16.0 if edm4hep is enabled. CMake does not check this so far, I'm adding a CMake-level check here.
Let me know what you think!
BEGINRELEASENOTES
ENDRELEASENOTES