Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two compiler warnings #1151

Merged
merged 1 commit into from Aug 4, 2023
Merged

Fix two compiler warnings #1151

merged 1 commit into from Aug 4, 2023

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Aug 2, 2023 •
edited by andresailer

BEGINRELEASENOTES

  • Limits object: fix string creation of Limit::toString, this will now also print the relevant "particles"
  • Shapes: remove "move" from return of dimensions()

ENDRELEASENOTES

@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited

Test Results

       6 files         6 suites   6h 47m 21s ⏱️
   355 tests    354 ✔️ 0 💤 1 ❌
1 055 runs  1 054 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 44a66c1.

♻️ This comment has been updated with latest results.

@andresailer
Copy link
Member

The clang-tidy guard test I need to move to a different stack now.

The dev3/dev4 failures seem suspicious though

https://github.com/AIDASoft/DD4hep/actions/runs/5743030202/job/15566407227?pr=1151#step:4:4676

@andresailer andresailer merged commit 2089a34 into AIDASoft:master Aug 4, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmcarcell @andresailer