Geant4Output2EDM4hep: allow reuse of collection names... again #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are in both cases
They also occur on master, e.g. https://github.com/AIDASoft/DD4hep/actions/runs/5761723352/job/15620106338#step:4:5201. |
|
Yes, the test failures are under investigation in #1153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have gotten broken again here. We do NOT want to assign an empty collection since it overwrites the hits that are already in the collection; we just want to ensure that the named collection exists and the map should take care of the construction if it doesn't.
The ClientTest 'framework' doesn't easily allow for a unit test to prevent this from regressing (it's mostly based on regexes on failures), but please comment on ideas for tests there.
BEGINRELEASENOTES
ENDRELEASENOTES