New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geant4InputHandling: Treat Ions with Excitation Energy? #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with the hepmc file is failing here as well, so something else is broken probably. |
Merged
andresailer
changed the title
Geant4InputHandling: reject GEN_DOC, GEN_BEAM, GEN_OTHER particles
Geant4InputHandling: Treat Ions with Excitation Energy?
Aug 18, 2022
andresailer
force-pushed
the
rejectGen
branch
2 times, most recently
from
August 26, 2022 06:50
a4d5a64
to
55b8294
Compare
andresailer
commented
Oct 28, 2022
andresailer
commented
Oct 28, 2022
andresailer
commented
Oct 28, 2022
Closed
andresailer
force-pushed
the
rejectGen
branch
from
January 27, 2023 09:22
93330f2
to
2a5fe93
Compare
andresailer
force-pushed
the
rejectGen
branch
2 times, most recently
from
February 7, 2023 09:43
263f61f
to
c71dfab
Compare
Have to ignore exceptions in the test
|
andresailer
force-pushed
the
rejectGen
branch
from
February 7, 2023 14:21
2cd50eb
to
41f78ca
Compare
This change also affects other cases where suddenly ions start showing up. :/ |
This needs a better solution for the tests. |
If excited state is already known we get it via FindIon. Otherwise we use GetIon to create zero-state ions and print warnings for lvl>0
andresailer
force-pushed
the
rejectGen
branch
from
February 23, 2023 16:06
3c6ede0
to
237092d
Compare
andresailer
force-pushed
the
rejectGen
branch
from
February 23, 2023 16:10
237092d
to
17110aa
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @espadaro1,
When I try this locally with the hepmc file from #918 I get a terrible crash at the end, I am not sure if this is because of my setup, or something else going wrong.
Could you try this patch in your local installation? I hope I find some more time to test this myself as well.
Updated following #935
BEGINRELEASENOTES
ENDRELEASENOTES