Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4InputHandling: Treat Ions with Excitation Energy? #920

Merged
merged 8 commits into from Feb 23, 2023

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Jun 20, 2022

Hi @espadaro1,

When I try this locally with the hepmc file from #918 I get a terrible crash at the end, I am not sure if this is because of my setup, or something else going wrong.

Could you try this patch in your local installation? I hope I find some more time to test this myself as well.

Updated following #935

BEGINRELEASENOTES

ENDRELEASENOTES

@andresailer
Copy link
Member Author

Test with the hepmc file is failing here as well, so something else is broken probably.

@andresailer andresailer mentioned this pull request Jul 26, 2022
@andresailer andresailer changed the title Geant4InputHandling: reject GEN_DOC, GEN_BEAM, GEN_OTHER particles Geant4InputHandling: Treat Ions with Excitation Energy? Aug 18, 2022
@andresailer andresailer force-pushed the rejectGen branch 2 times, most recently from a4d5a64 to 55b8294 Compare August 26, 2022 06:50
DDTest/CMakeLists.txt Outdated Show resolved Hide resolved
DDTest/CMakeLists.txt Outdated Show resolved Hide resolved
DDTest/CMakeLists.txt Outdated Show resolved Hide resolved
@andresailer
Copy link
Member Author

Have to ignore exceptions in the test

  -------- WWWW ------- G4Exception-START -------- WWWW -------
  *** G4Exception : PART5107
        issued by : G4IonTable::FindIon()
  Isomer level 9 may be ambiguous.
  *** This is just a warning message. ***
  -------- WWWW -------- G4Exception-END --------- WWWW -------

@andresailer
Copy link
Member Author

This change also affects other cases where suddenly ions start showing up. :/

@andresailer
Copy link
Member Author

This needs a better solution for the tests.

@andresailer andresailer enabled auto-merge (rebase) February 23, 2023 16:54
@andresailer andresailer merged commit d08e013 into AIDASoft:master Feb 23, 2023
@andresailer andresailer deleted the rejectGen branch February 23, 2023 17:33
@andresailer andresailer linked an issue Feb 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagation of ions HepMC3 reader with Pythia8 Argantyr generator: status checker not implemented
1 participant