Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Geant4OpticalTrackerAction which stops-and-kills optical photons #967

Merged
merged 1 commit into from Sep 15, 2022

Conversation

wdconinc
Copy link
Contributor

In the EIC detectors we use various photo-sensitive pixel planes in the DIRC and RICH detectors. This is similar to a tracker in the overall SD action sense, but instead of requiring optical photons energy deposition in the material of the sensor (e.g. SiPM, LAPPD, AC-LGAD), we often don't model the optical properties of the materials in the sensors and simply stop-and-kill the optical photon when it reaches the sensor. This is an SD action that achieves this.

I have no geometry to easily test the processFastSim functionality with.

BEGINRELEASENOTES

  • Geant4OpticalTrackerAction which stops-and-kills optical photons for e.g. SiPM sensor planes

ENDRELEASENOTES

@andresailer
Copy link
Member

Hi Wouter,
Do you have a simple detector that we could add to the examples to use this plugin?

@wdconinc
Copy link
Contributor Author

simple detector

Well... Probably not an entire RICH? Though maybe @c-dilks would be open to turning our dual RICH into a standalone example that demonstrates this. Otherwise we can also do our proximity-focused RICH which is a bit simpler.

@c-dilks
Copy link
Contributor

c-dilks commented Sep 1, 2022

Hi @wdconinc, I opened wdconinc#2 targeting your fork's branch, which adds a PFRICH. It needs some more work to make it nice, but I think I see the increase in the number of hits. See the description within for more details.

wdconinc pushed a commit to eic/epic that referenced this pull request Sep 3, 2022
…#89)

### Briefly, what does this PR introduce?
The dRICH sensitive detector now uses `Geant4OpticalTrackingAction` (see AIDASoft/DD4hep#967 and https://eicweb.phy.anl.gov/EIC/NPDet/-/merge_requests/270/). This PR removes `RINDEX` tables from the RICH sensor surfaces, as it's not clear where they came from and they weren't needed in the ATHENA proposal (which effectively also used `Geant4OpticalTrackerAction`).

@alexander-kiselev @chchatte92 @ajitkmaurya 
With these changes, we go from about 60 raw dRICH hits to almost 300, for a 40 GeV pion.

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users need to make to their code?
No

### Does this PR change default behavior?
Not beyond the dRICH
@wdconinc
Copy link
Contributor Author

Do you have a simple detector that we could add to the examples to use this plugin?

Example added as #974. Not sure if it's what you'd consider 'simple' but it is at least much simpler than how we are using it in production :-D

So, I'd suggest either merging this and moving example discussion to the example PR, or closing this and merging the tracker SD action as part of the example PR.

@andresailer
Copy link
Member

Thanks! I will merge this, and then #974 can be rebased to add the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants