Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken constness in meta data handling in EventStore #136

Closed
hegner opened this issue Sep 16, 2020 · 0 comments · Fixed by #192
Closed

Broken constness in meta data handling in EventStore #136

hegner opened this issue Sep 16, 2020 · 0 comments · Fixed by #192

Comments

@hegner
Copy link
Collaborator

hegner commented Sep 16, 2020

The recently added methods for meta data handling violate the concept of constness and thread-safety. Despite being declared as mutable internally, the return values of the meta data getters have to be const as well. Otherwise, multithreaded users of PODIO do not have a chance to implement concurrency.

Maybe the design of the meta data handling needs to be rethought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant