Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playsInline for videos with autoPlay attribute #979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jahirfiquitiva
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This will prevent videos from playing in full-screen unexpectedly on iOS.

Read more: https://jahir.dev/blog/autoplay-videos-ux

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

This will prevent videos from playing in full-screen unexpectedly on iOS.

Read more: https://jahir.dev/blog/autoplay-videos-ux
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:37pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:37pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8116332381

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.524%

Totals Coverage Status
Change from base Build 8101237008: 0.0%
Covered Lines: 884
Relevant Lines: 27799

💛 - Coveralls

@jahirfiquitiva
Copy link
Contributor Author

This is a video showing the unexpected behavior ... all I did was switch to the "Million Lint" tab

trim.0B79206B-E67A-4F1F-9AF6-8D083F70D545.MOV

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Mar 25, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 10, 2024
@jahirfiquitiva
Copy link
Contributor Author

@aidenybai @tobySolutions any chance you could look into this, please?

@github-actions github-actions bot removed the Stale label Apr 11, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants