Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Extension - Warning does not appear #2

Closed
corvec opened this issue Apr 16, 2018 · 2 comments
Closed

Chrome Extension - Warning does not appear #2

corvec opened this issue Apr 16, 2018 · 2 comments

Comments

@corvec
Copy link

corvec commented Apr 16, 2018

I installed the extension from the Chrome Web Store on Chrome 65.0.3325.181 on a MBP running macOS Sierra (10.12.6). I've verified this behavior with my normal extensions and in Incognito mode with no other extensions enabled. Its current behavior is as follows:

  • Plugin icon displays some number that may or may not be correct. Most pages are showing 99+. https://umpox.github.io/zero-width-detection/ shows 9.
  • When selecting text that I know to have zero-width character in it, I don't get a warning of any kind.
  • When left-clicking on the Github / Twitter links in the extension's window after clicking on the icon, nothing happens (the page does not load). Middle-clicking or right-clicking and clicking on "Open in..." allows me to open the links in a new tab, though.
@aido179
Copy link
Owner

aido179 commented Apr 16, 2018

Thanks for the response.

  1. Duplicate of this issue.
  2. Can you post which character isn't being detected? The detection function is fairly naive - and will more than likely need improvement over time.
  3. Thanks - will figure that out asap.

@aido179
Copy link
Owner

aido179 commented Apr 17, 2018

Fixed third part of your issue in 82421a0

Please create another issue for specific characters that are not detected.

@aido179 aido179 closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants