Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an Issue. Just a thank you! #71

Closed
time-killer-games opened this issue Dec 17, 2021 · 3 comments
Closed

Not an Issue. Just a thank you! #71

time-killer-games opened this issue Dec 17, 2021 · 3 comments

Comments

@time-killer-games
Copy link

time-killer-games commented Dec 17, 2021

This may be closed when you see it. I just wanted to say thanks for making this, you're a life saver. I orignally wrote a library which uses native dialogs and is cross-platform but maintenance on macOS became a bit annoying, so this makes for a nice fallback solution that won't face constant breakage every new major OS version, like I would I've had to deal with using NSOpenPanel and NSSavePanel.

I would like to contribute an example for using this with the SDL2Renderer, as an extra means of saying thank you.

The example will look similar to this:

IPRQpmz

I'll submit a pr shortly. Thanks again!
Samuel

@aiekick
Copy link
Owner

aiekick commented Dec 17, 2021

thanks :)

its a pleasure, to see that kind of post :)

@aiekick aiekick closed this as completed Dec 17, 2021
@time-killer-games
Copy link
Author

time-killer-games commented Dec 17, 2021

@aiekick hey, I'm ready to make the pr, was wondering where the files should go in your repository before getting started:

https://github.com/time-killer-games/ImGuiFileDialogSDL2RendererExample

@aiekick
Copy link
Owner

aiekick commented Dec 18, 2021

sorry, i not understood you would like to post a pr for ImGuiFileDialog with SDL.
its not necessary.

i can just a add a config in the CMakeList.txt of the current app in master with the sdl as a submodule if needed

but its not necessary since each guys can easily use ImGuiFileDialog with their current imgui configuration.

the purpose of the app was just to show how to use it. this is eactly the same code for each backend.
and im working with glfw, and i need to maintain this app for each modification, so its better if you let me write the app.

sorry, but thanks for your understanding and your consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants