Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change register-kernel to manual kernel registration #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

appleparan
Copy link

@appleparan appleparan commented Jan 17, 2024

It fixes #1 and #2 .The actual cause of this bug is the incorrect assumption that jupyter must be installed in the global versions. So, instead of automatically updating the kernel in all existing virtualenvs, I changed it to manually register the kernel using register-kernel.

It might resolve #6, too.

Pros

  • It fixes all problems in the issue.

Cons

  • You need to execute pyenv register-kernel after pip install jupyter by yourself.

@appleparan appleparan changed the title Check jupyter command on registering kernels Change to manual kernel registration command Jan 22, 2024
@appleparan appleparan changed the title Change to manual kernel registration command Change register-kernel to manual kernel registration Jan 22, 2024
* Why: Automatic registration has an incorrect assumption that jupyter must be installed globally
* Remove batch script for adding jupyter kernels
* Remove after_install hook because it is redundant now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall doesn't delete the kernel
1 participant