-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-style tabular table to match UX #18
Comments
Check with Charlotte re. the styling. We probably do want to update styling the table, but not necessarily to match the existing tables, which are static. For example, we will need to handle overflow text (e.g. in the 'Shared cosponsors') column. Some of the styling in tabulator is functional: the vertical dividers are selectable/dragable. The rows in tabular are also styled to be selectable. While we have not implemented a select function for the rows, we may (e.g. selecting a row populates the Sponsors table, or opens that bill in a new browser tab). Take a look at the themes provided for Tabulator, to see if we can re-use or extend one of these: http://tabulator.info/examples/4.1?#example-table-theme-bootstrap4 |
Oh neat, it already has a bootstrap theme that we can implement. In that case, lets just import the bootstrap theme for now and match the style. Once that's finished, ux can guide us on fleshing out features like row selection. I'll open up issues for the other static tables, which need to be hydrated with relevant data. |
Also adjust the tabulator settings to make it responsive. See http://tabulator.info/docs/4.1/layout |
I tried to merge |
yea i think we can just merge |
* initializing home folder + home template * #19 adding home routing to header * Redirect root to home * Update homepage text * Add typeahead for bills; need to add data and link to url * Select and navigation working; back button not set * Add script to gather bill names * Add jquery typeahead * Working with typeahead.js; need to parse data * Typeahead working with bills * #18 adding tabular styling and new headers * adding styling to search bills in home page * using bill_list in billsData array + adding limit to dropdown * Provide the sponsors_table data Co-authored-by: Ari Hershowitz <arihershowitz@gmail.com>
Closed witht he merging of #33 |
Currently the tabular implementation of the tables don't match the UX. We'll need to implement the current CSS in bootstrap tables to reskin the tabular tables.
Tabular:
![Screen Shot 2020-09-14 at 11 09 51 PM](https://user-images.githubusercontent.com/7513454/93160946-76d48300-f6df-11ea-8ca9-97254367277c.png)
Current bootstrap iteration (matching UX):
![Screen Shot 2020-09-14 at 11 10 02 PM](https://user-images.githubusercontent.com/7513454/93160981-8bb11680-f6df-11ea-8f73-bf504886b687.png)
The text was updated successfully, but these errors were encountered: