Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put examples of search formats below the search bar & changes to reflect wireframe #272

Closed
nkinaba opened this issue Mar 31, 2021 · 6 comments
Assignees
Labels
Search Bar Search bar located in home page

Comments

@nkinaba
Copy link
Collaborator

nkinaba commented Mar 31, 2021

  1. Input search formats below the search bar as seen in the wireframe
  2. Change grey text inside the search bar to “Search for Legislation”
  3. Remove prompt “Search for Legislation, Committee Materials, Congressional Record, or Members of Congress with basic or advanced search settings.”
  4. Include "th" for the congress filter for all sessions EX: 117th, 116th

Wireframe
Screen Shot 2021-04-06 at 3 25 16 PM

@nkinaba nkinaba added this to the Week of March 30, 2021 milestone Mar 31, 2021
@nkinaba nkinaba added the Search Bar Search bar located in home page label Mar 31, 2021
@aih
Copy link
Collaborator

aih commented Apr 3, 2021

What is the exact text that should go in the search bar? Currently, typing H.R. 200 or hr200 or 200 will pull up results, as will HJRES1500 , HjRes, H.J.RES1500 and more.

@nkinaba nkinaba changed the title Put examples of all valid search formats in grey text in the search bar Put examples of search formats below the search bar & changes to reflect wireframe Apr 6, 2021
@aih
Copy link
Collaborator

aih commented Apr 9, 2021

The search is case insensitive, removes spaces and supports search with and without periods.

So the example text could be:
Examples: s5, hr5, hres5, hjres5, hconres5, sjres5, sconres5, sres5

The stages are:
'S.', 'H.R.', 'H.Res.', 'H.J.Res.', 'H.Con.Res.', 'S.J.Res.', 'S.Con.Res.', 'S.Res.'

aih added a commit that referenced this issue Apr 9, 2021
aih added a commit that referenced this issue Apr 9, 2021
@aih
Copy link
Collaborator

aih commented Apr 9, 2021

Implemented:
image

@aih aih closed this as completed Apr 9, 2021
@smplater
Copy link
Collaborator

The examples of the Bills that can be searched should be below the search bar not in the search bar, as the wireframe shows below. "Search for Legislation" should be the text in the search bar.
113786802-e2c41a80-9707-11eb-88fe-b7b9a7f1c27a

@aih
Copy link
Collaborator

aih commented Apr 14, 2021

@ayeshamk see the mock-up above. The 'Search for legislation' text will be in italics, as @placeholder text.

@ayeshamk ayeshamk removed their assignment Apr 20, 2021
@aih
Copy link
Collaborator

aih commented May 4, 2021

image
Implemented in PR #341

@aih aih closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search Bar Search bar located in home page
Projects
None yet
Development

No branches or pull requests

6 participants