-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sap biden ayesha #222
Conversation
…P_Biden_Ayesha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a small change (belongs_to
field changed to something more descriptive, like administration
) and documentation.
operations = [ | ||
migrations.AddField( | ||
model_name='statement', | ||
name='belongs_to', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change 'belongs_to' to 'administration'; it is a more descriptive field name and will help future developers understand what the field means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a branch with this change that you could merge into this branch.
|
||
To load Relevant Committee Documents data use the following instructions: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation in SCRAPING.adoc for what data is scraped, how to initiate the data. Also in UPDATES_CELERY.adoc to describe the task you've set up for SAP.
One more issue as I try it out: it is confusing to have |
See also #225. I encountered an issue with saving, possibly due to using |
server_py/flatgov/common/tasks.py
Outdated
from .biden_statements import load_statements | ||
|
||
|
||
@periodic_task(run_every=(crontab(minute=0, hour=0), name="scrape-biden-statements-once-a-day", ignore_result=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
celery @periodic_task
decorators are deprecated
See https://stackoverflow.com/a/56071240/628748
I'll move this to celery.py
No description provided.