Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/committees cosponsors ayesha #328

Merged
merged 9 commits into from
Apr 26, 2021
Merged

Conversation

ayeshamk
Copy link
Collaborator

No description provided.

@aih
Copy link
Collaborator

aih commented Apr 23, 2021

The copy-to-clipboard and download CSV features are great!

Sorting does not appear to be working:
http://localhost:8000/bills/116hr1500
This correctly shows the † and * for sponsor and original cosponsor, respectively, but the top of the list should be: a) the sponsor (Maxine Waters) and any member with rank 1 on a committee of jurisdiction (also Maxine Waters). The others (I think) should be shown in rank order.
image

image

@aih aih self-requested a review April 23, 2021 21:48
@ayeshamk
Copy link
Collaborator Author

Per discussion on Tuesday with Daniel, I implemented the following sorting logic. Find my comment below after the meeting. #306 (comment)

@aih
Copy link
Collaborator

aih commented Apr 23, 2021

From your comment in #306:

  1. Original bill sponsors (D/R) -- Sources for 'in Focus' information  #1 and Adam's Sandbox #2 sponsors if they are of different parties, otherwise only the 1st sponsor.
  1. Co-sponsors with rank 1.

In 116hr1500, Maxine Waters is both the sponsor and a sponsor with rank 1, so she should be shown first.

@ayeshamk
Copy link
Collaborator Author

From your comment in #306:

  1. Original bill sponsors (D/R) -- Sources for 'in Focus' information  #1 and Adam's Sandbox #2 sponsors if they are of different parties, otherwise only the 1st sponsor.
  1. Co-sponsors with rank 1.

In 116hr1500, Maxine Waters is both the sponsor and a sponsor with rank 1, so she should be shown first.

I picked co-sponsors in the sort, it looks like. I'll add sponsors too.

@aih
Copy link
Collaborator

aih commented Apr 26, 2021

And after that, any rank 1 cospsonsors

@ayeshamk
Copy link
Collaborator Author

Changed. Working as expected.

image

@aih
Copy link
Collaborator

aih commented Apr 26, 2021

Confirmed
image

@ayeshamk
Copy link
Collaborator Author

ayeshamk commented Apr 27, 2021

@aih Looks like the merges changed the sorting logic. The orders are different now than what I posted before above for 116hr1500. Here is a screenshot of what we have now on the site:

image

Here is what I originally implemented:

image

The results are the same; it is still showing the expected list. However, the orders are different.

@ayeshamk
Copy link
Collaborator Author

It is ordered alphabetically now. We do not want the sorting options in the top menu. Daniel asked them to be removed.

image

@aih
Copy link
Collaborator

aih commented Apr 27, 2021

@ayeshamk I believe this is a browser cache issue. Check that the version number is 0.3.0. This version is tied to the git tag; I'll add git tags to future significant updates as well, so we can confirm that the expected version is in the UI.

image

@ayeshamk
Copy link
Collaborator Author

@aih I see the expected behavior from an incognito window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants