Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: change results node name to ouput_parameters #30

Closed
abelcarreras opened this issue Sep 22, 2017 · 4 comments
Closed

Suggestion: change results node name to ouput_parameters #30

abelcarreras opened this issue Sep 22, 2017 · 4 comments

Comments

@abelcarreras
Copy link

If an ouput_parameters node is generated the contents can be easily accessed using verdi:

verdi calculation res pk_number

I can be a good idea to rename the results node name to get better integration with aiida

https://github.com/DropD/aiida-vasp/blob/317a9ce56d7c5a346f7332b51f9d05908fb0991b/aiida_vasp/parsers/vasp.py#L64

@DropD
Copy link
Contributor

DropD commented Sep 22, 2017

@greschd You have been using the plugin more than me, is there a reason to keep it as is?

@DropD DropD added this to the Version 1 milestone Sep 22, 2017
@greschd
Copy link
Contributor

greschd commented Sep 22, 2017

No, I don't think there's a strong reason to keep it. We should maybe check how the aiida-quantumespresso plugin does this, to be as consistent as possible.

@DropD
Copy link
Contributor

DropD commented Nov 1, 2017

It seems that output_parameters is the current name for this

@DropD
Copy link
Contributor

DropD commented Nov 6, 2017

fixed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants