Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: energy and forces parsing #33

Closed
abelcarreras opened this issue Oct 2, 2017 · 5 comments
Closed

Request: energy and forces parsing #33

abelcarreras opened this issue Oct 2, 2017 · 5 comments
Assignees
Labels
feature p0 - critical affects scientific correctness, data provenance, or leads to crashes, merits immediate release

Comments

@abelcarreras
Copy link

Hi,

I would like to use AiiDA to make phonon calculations.
Therefore I need this plugin to parse at least total energy and atomic forces to be able to test it.
I suggest to use the same quantumespresso scheme:
Energy in output_parameters node (ParametersData) and forces in output_array node (ArrayData).
Also to parse stress tensor would be nice.

I think it is important to keep the output structure as close as possible among all the plugins.
Then, developing workflows that work using many codes is much easier.

Thanks,

@greschd
Copy link
Contributor

greschd commented Oct 2, 2017

Hi,

I agree that we should keep the QE and VASP plugins as close in interface as possible. As a side note, I think it's still a good idea to have an adapter for the DFT plugins in the workflow to allow catching inconsistencies in these plugins.

More to the topic at hand: Do you have or know of an existing parser for total energy and forces we could include in the plugin? Also, do you know if this information is contained in the vasprun.xml file?

@abelcarreras
Copy link
Author

Yes, all that information is contained in the vasprun.

It is possible to use pymatgen to parse this file. For now
I think it is a fast way to implement the parsing but in the
future I think we should consider to implement it using xml
python library (which is the one used by pymatgen).

Some things are not parsed in pymatgen such us born charges (which I need).
Currently I am using Mario's old vasp plugin and I made many modifications
for parsing those things. It is pretty simple I can share the code if you want.

@DropD
Copy link
Contributor

DropD commented Oct 2, 2017

Yes, that would be very helpful. Absolutely ideal would also be a vasprun.xml file with the corresponding output of the parser, so we can easily test for correctness.

@DropD DropD added feature p1 - important required feature or major usability issue labels Oct 2, 2017
@abelcarreras
Copy link
Author

abelcarreras commented Oct 4, 2017

I prepared a very minimal example of vasprun.xml parsing using both pymatgen and xml library
https://github.com/abelcarreras/vasp_parser.

Of course you can also see how this is implemented in Mario's plugin but it is really dirty now:
https://github.com/abelcarreras/aiida_extensions/blob/development/plugins/parsers/vasp/instruction/data/array_data_parser.py
https://github.com/abelcarreras/aiida_extensions/blob/development/plugins/parsers/vasp/instruction/data/output_parameters.py

@abelcarreras abelcarreras reopened this Oct 4, 2017
@DropD DropD added p0 - critical affects scientific correctness, data provenance, or leads to crashes, merits immediate release and removed p1 - important required feature or major usability issue labels Oct 12, 2017
@DropD
Copy link
Contributor

DropD commented Nov 6, 2017

Implemented as of #53

@DropD DropD closed this as completed Nov 6, 2017
@DropD DropD self-assigned this Jan 16, 2018
@DropD DropD added this to To Do in VaspImmigrant - Import Phonondb via automation Jan 16, 2018
@DropD DropD moved this from To Do to Done in VaspImmigrant - Import Phonondb Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature p0 - critical affects scientific correctness, data provenance, or leads to crashes, merits immediate release
Projects
No open projects
Development

No branches or pull requests

3 participants